Skip to content

Python: Refactor definitions query, add queries for ide search#3405

Merged
tausbn merged 5 commits into
github:masterfrom
jcreedcmu:jcreed/jump-to-def-python
May 7, 2020
Merged

Python: Refactor definitions query, add queries for ide search#3405
tausbn merged 5 commits into
github:masterfrom
jcreedcmu:jcreed/jump-to-def-python

Conversation

@jcreedcmu

Copy link
Copy Markdown
Contributor

This enables jump-to-definition and find-references in the VS Code
extension, for python source archives.

@jcreedcmu jcreedcmu requested a review from tausbn May 4, 2020 15:26
@jcreedcmu jcreedcmu requested a review from a team as a code owner May 4, 2020 15:26
This enables jump-to-definition and find-references in the VS Code
extension, for python source archives.
@jcreedcmu jcreedcmu force-pushed the jcreed/jump-to-def-python branch from 90888d4 to b0f72eb Compare May 4, 2020 15:27

@RasmusWL RasmusWL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor adjustment to the QLdoc.

Can you explain why we need kind at all? What could it be other than "Definition"? and if it took other values, would you imagine that definitionOf would accept other values than kind = "Definition"?

Comment thread python/ql/src/analysis/DefinitionTracking.qll Outdated
jcreedcmu and others added 2 commits May 5, 2020 09:40

@tausbn tausbn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to have 4-space indentation (for consistency with the surrounding code), but otherwise LGTM. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants